Types Rework #42
Merged
Types Rework #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helper types in mcp.server.types got really confusioning during implementation as they overlapped with mcp.types. I now believe it is better if we stay more low level to the spec types. To do this, we now only use mcp.types everywhere. We renamed mcp.server.types to mcp.server.models and removed it to the absolute minimum.
We will be a bit more low level and expect callees to import mcp.types instead of relying in re-exported types. This makes usage more explicit and avoids potential collisions in mcp.server.
dsp-ant
force-pushed
the
davidsp/types
branch
from
3b344e7 to
ec8c85e
Compare
jspahrsummers
approved these changes
Nov 11, 2024
gspencergoog
pushed a commit
to gspencergoog/mcp-python-sdk
that referenced
this pull request
Jul 29, 2025
…justin/is-error-optional `CallToolResult.isError` should be optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks how we deal with types from the spec and other types in the Python SDK. Namely it removes some helper types that were aimed to make usage slightly simpler. It also removes all re-exported types in mcp.server.
The goal is to expose more consistent modules with less potential for name collision. We are also deliberately staying a bit more low-level in how we expect results to be returned.
The best way to review this PR is by going commit to commit instead of the full PR.
Fixes #34