Skip to content

Conversation

dsp-ant
Copy link
Member

@dsp-ant dsp-ant commented Nov 11, 2024

Rework Github Actions and add PyPI release workflow:

  1. We take all checks into a shared workflow.
  2. We add a file for checks on main and one for checks on PRs. (for now we could combine them but i think it'll be useful in the future)
  3. We add PyPI release workflow that we tested with TestPyPI.
  4. We setup Github environments such that @jspahrsummers or @dsp-ant MUST approve the final release workflow.

https://github.com/modelcontextprotocol/python-sdk/actions/runs/11787194910/job/32832022351
https://github.com/modelcontextprotocol/python-sdk/actions/runs/11787306038/job/32832342605

After testing against TestPyPI i removed the code to do so.

Copy link
Member

@jspahrsummers jspahrsummers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the advantage of keeping things in separate workflow files, versus using ifs within one file, but not a big deal.

I also have a minor preference for using GitHub Releases to trigger automation behaviors, versus just tags (which aren't as prominent in the UI), but YMMV.

@dsp-ant
Copy link
Member Author

dsp-ant commented Nov 12, 2024

Releases are best I think. Let me see that I can change it. I am just not super fluent with Github best practises

@dsp-ant dsp-ant merged commit 3d670a3 into main Nov 12, 2024
5 checks passed
@dsp-ant dsp-ant deleted the test-release branch November 12, 2024 11:36
gspencergoog pushed a commit to gspencergoog/mcp-python-sdk that referenced this pull request Jul 29, 2025
…davidsp/fix-docs

docs: fix requests.HTTPError -> httpx.HTTPError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants