Skip to content

Conversation

ihrpr
Copy link
Contributor

@ihrpr ihrpr commented Apr 22, 2025

Noticed there are two unformatted files that keep popping in when I run uv run ruff format .

@ihrpr ihrpr requested a review from dsp-ant April 22, 2025 09:14
@jerome3o-anthropic jerome3o-anthropic merged commit b4c7db6 into main Apr 23, 2025
8 checks passed
@jerome3o-anthropic jerome3o-anthropic deleted the ihrpr/format-and-tests branch April 23, 2025 04:06
@Kludex
Copy link
Member

Kludex commented Apr 24, 2025

Why is this mismatch happening?

@Kludex
Copy link
Member

Kludex commented Apr 24, 2025

We are running this in the pipeline:

- name: Run ruff format check
run: uv run --no-sync ruff check .

...and this locally:

hooks:
- id: ruff-format
name: Ruff Format
entry: uv run ruff
args: [format]
language: system
types: [python]
pass_filenames: false
- id: ruff
name: Ruff
entry: uv run ruff
args: ["check", "--fix", "--exit-non-zero-on-fix"]
types: [python]
language: system
pass_filenames: false

We need to match both. We need to run the pre-commit job on the pipeline as well.

gspencergoog pushed a commit to gspencergoog/mcp-python-sdk that referenced this pull request Jul 29, 2025
…/basil/changelog

add structured output to changelog, removed stale batching ref in docs
saqadri pushed a commit to saqadri/stdio-fixes that referenced this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants