Skip to content

Conversation

@fcestari
Copy link

@fcestari fcestari commented May 2, 2025

  • Add auth to TOC
  • Specify python for code block highlighting
  • Format auth example

Motivation and Context

Update readme

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

fcestari added 2 commits May 2, 2025 19:23
- Add auth to TOC
- Specify python for code block highlighting
- Format auth example
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for working on this!

there was a typo in the README around auth_provider, which is fixed now and should be rebased on top

@fcestari
Copy link
Author

Hi @ihrpr, my pleasure. I committed the proposed changes - hopefully I got your message right. Let me know.

@fcestari fcestari requested a review from ihrpr June 8, 2025 11:36
@ihrpr
Copy link
Contributor

ihrpr commented Jul 10, 2025

Thank you so much for contribution and improving the README. Sorry this PR got lost and wasn't reviewed on time. Since then, the SDK moved to the new spec, where mcp server acts as RS, hence the documentation is out of date in this PR. Closing this PR, really appreciate the help in improving the SDK.

@ihrpr ihrpr closed this Jul 10, 2025
gspencergoog pushed a commit to gspencergoog/mcp-python-sdk that referenced this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants