-
Notifications
You must be signed in to change notification settings - Fork 2.7k
StreamableHttp - update docs #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Couple v minor ideas inline but feel free to ignore
README.md
Outdated
|
||
### Mounting to an Existing ASGI Server | ||
|
||
> **Note**: SSE transport is being superseded by streamable HTTP transport. Consider using streamable HTTP for production deployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw the wording here is slightly different from the prior note
README.md
Outdated
asyncio.run(run()) | ||
``` | ||
|
||
Clients can also connect using streamable HTTP transport: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk does this deserve its own section header?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the "how should I decide what transport my client should use" noob question might come to mind here - if there's somewhere else in the docs where we cover this, it might be a nice thing to link to
The base branch was changed.
…-deprecation-note Add replacement warning about SSE to Streamable HTTP Transport in the User Guide
Updating docs before the release