Skip to content

Conversation

DanielAvdar
Copy link
Contributor

@DanielAvdar DanielAvdar commented May 13, 2025

add windows tests for ci, required for preventing and solving issues related to windows.

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@DanielAvdar DanielAvdar marked this pull request as ready for review May 13, 2025 18:30
@DanielAvdar
Copy link
Contributor Author

DanielAvdar commented May 13, 2025

@ihrpr ihrpr added this to the HPR milestone May 13, 2025
ihrpr
ihrpr previously approved these changes May 14, 2025
Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

I'll make changes in the config

Please can you rebase and I'll merge

Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@ihrpr ihrpr merged commit b8f7b02 into modelcontextprotocol:main May 14, 2025
10 checks passed
gspencergoog pushed a commit to gspencergoog/mcp-python-sdk that referenced this pull request Jul 29, 2025
…/ihrpr/elicitation-tiny-fix

Change content type in  ElicitResult
saqadri pushed a commit to saqadri/stdio-fixes that referenced this pull request Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants