Fix: Convert sync tests using async fixtures to async tests #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two test methods in test_auth.py were using the async oauth_provider fixture but were not marked as async tests: - test_scope_priority_client_metadata_first - test_scope_priority_no_client_metadata_scope This caused AttributeError: 'coroutine' object has no attribute 'client_metadata' when running tests locally with pytest-anyio. Added @pytest.mark.anyio decorator and converted both methods to async, following the pattern established in commit 9dad266.
|
Had replaced this PR with #903 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes test failures in
test_auth.pywhere two synchronous test methods were incorrectly using an async fixture.Problem
Two test methods were using the async
oauth_providerfixture but were not marked as async tests:test_scope_priority_client_metadata_firsttest_scope_priority_no_client_metadata_scopeThis caused:
Solution
Added
@pytest.mark.anyiodecorator and converted both methods toasync def, following the pattern established in commit 9dad266.Testing
uv run ruff check)uv run ruff format)uv run pyright)Note
The CI currently has
continue-on-error: truefor tests, which is why these failures weren't caught. This might be worth addressing in a separate issue.