Skip to content

Conversation

ElGreKost
Copy link

@ElGreKost ElGreKost commented May 31, 2025

Deleted the file prompt_manager.py since now all the files in the directory use the improved version of it that is manager.py

@ElGreKost ElGreKost changed the title no file was using the prompt_manager.py module it was just hanging. Deleted hanging prompt_manager.py module since no file was using it. May 31, 2025
@ElGreKost ElGreKost changed the title Deleted hanging prompt_manager.py module since no file was using it. Deleted hanging prompt_manager.py module since no file was using it. May 31, 2025
Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ElGreKost
Copy link
Author

Not in the modelcontextprotocol:main where I PR.

You show me a different fork from jlowin

In the main repo in prompts folder

There are the

And what I'm saying is they both implement class PromptManger but the prompt_manager.py version is never called by any file but has the same functionality.

And that's why this should be deleted.

(and to be consistent with the tools directory

Maybe even rename the manager to prompt_manager like the tool_manager in tools

@ihrpr
Copy link
Contributor

ihrpr commented Jul 10, 2025

Maybe even rename the manager to prompt_manager like the tool_manager in tools

yes, I think that would be great

(I can't directly push to this PR, but happy to take commits and create a new PR with renaming, or please apply the changes and we can merge)

@ElGreKost ElGreKost requested review from a team and dsp-ant July 31, 2025 11:03
@Kludex
Copy link
Member

Kludex commented Aug 9, 2025

This was already merged, I think.

@Kludex Kludex closed this Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants