Add streamable_http_client and deprecate old usage
#869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
commented
Jun 2, 2025
| - [Prompts](#prompts) | ||
| - [Images](#images) | ||
| - [Context](#context) | ||
| - [Authentication](#authentication) |
There was a problem hiding this comment.
My IDE added those... Which seems correct.
Kludex
commented
Jun 2, 2025
Comment on lines
+85
to
+86
| timeout: float | timedelta = 30, | ||
| sse_read_timeout: float | timedelta = 60 * 5, |
There was a problem hiding this comment.
This is backwards compatible.
Kludex
commented
Jun 2, 2025
Comment on lines
+477
to
+478
| timeout.total_seconds(), | ||
| sse_read_timeout.total_seconds(), |
There was a problem hiding this comment.
We should use total_seconds(), not seconds. Only seconds was wrong.
Kludex
commented
Jun 2, 2025
| ), # url, headers, timeout, sse_read_timeout, terminate_on_close | ||
| ], | ||
| ) | ||
| async def test_establish_session_parameterized( |
There was a problem hiding this comment.
I've added type hints, and simplified this test.
This test shouldn't exist as is, it's very confusing, and full of mocking, but I just adapted it for the sake of my changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module is named
streamable_http_client, it doesn't make sense for the function to be calledstreamablehttp_client.