Skip to content

Conversation

ayush0x00
Copy link

Added clarification on the documentation

Motivation and Context

This elaboration is required so that users can effectively mount on different paths concerning their ASGI application

How Has This Been Tested?

No test is required. Just a documentation update. This feature was already present in the code.

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Fixes #872

Copy link
Contributor

@felixweinberger felixweinberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ayush0x00, thank you for your contribution! Apologies for the time it took to get to this review.

The existing docs just below already show this pattern sufficiently and comprehensively (see search_mcp example on lines ~530-550) so this would add some duplicated information. Also the code block should be using backticks with a python annotation.

Could you elaborate what in the docs isn't clear in your perspective to warrant this duplication?

gspencergoog pushed a commit to gspencergoog/mcp-python-sdk that referenced this pull request Jul 29, 2025
@felixweinberger
Copy link
Contributor

Hi @@ayush0x00, thanks again for your contribution.

I'm closing this PR for now - as explained I think the existing documentation already covers this pattern sufficiently.

Please feel free to reopen or resubmit a PR if you disagree!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mounting ASGI apps with a different named routes

2 participants