Skip to content

Conversation

basoko
Copy link

@basoko basoko commented Jun 12, 2025

The AuthorizationCode.redirect_uri field type is AnyUrl, but the example used AnyHttpUrl type.

This mismatch causes the redirect URI check in TokenHandler to fail, since it compares against AuthorizationCodeRequest.redirect_uri, which also expects AnyUrl.

Motivation and Context

It makes the simple-auth server example to work with simple-auth client example. Without the change when client requests to get the token it fails with a "Bad Request" error.

How Has This Been Tested?

Manually by running server and client examples locally.

Breaking Changes

No.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • [] I have added appropriate error handling
  • [] I have added or updated documentation as needed

Additional context

The AuthorizationCode.redirect_uri field type is AnyUrl, but the example
used AnyHttpUrl type.

This mismatch causes the redirect URI check in TokenHandler to fail,
since it compares against AuthorizationCodeRequest.redirect_uri, which
also expects AnyUrl.
@pcarleton
Copy link
Member

this part of the example has been simplified now

@pcarleton pcarleton closed this Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants