feat: Add GitHub Container Registry (GHCR) support#442
Closed
rafaelescrich wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
feat: Add GitHub Container Registry (GHCR) support#442rafaelescrich wants to merge 1 commit intomodelcontextprotocol:mainfrom
rafaelescrich wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
…alidator - Add GHCR (https://ghcr.io) as a supported OCI registry alongside Docker Hub - Refactor OCI validator to use scalable registry configuration system - Replace if-else chains with registry configuration map for better maintainability - Add RegistryConfig struct with auth functions, API URLs, and auth requirements - Support both authenticated and anonymous access for GHCR public repositories - Update official registry requirements documentation to include GHCR - Add comprehensive unit tests for registry configuration system - Maintain 100% backward compatibility with existing Docker Hub packages This addresses issue modelcontextprotocol#393 and makes it easier to add additional OCI registries in the future (e.g., Quay.io, GCR, ACR) by simply adding entries to the registry configuration map. Breaking changes: None - all existing packages continue to work unchanged.
Member
|
Hey @rafaelescrich, thanks a lot for opening this PR! 🙌 It looks like there’s already a similar one though (#439) that was opened a few hours earlier so maybe we can align efforts there? |
Author
Sure, do you think I need to close this one? |
Member
Let me do that 👍 And if you feel the other one missed anything you had in mind please feel free to comment/add it in. I think it’d be a great way to collaborate on this 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for GitHub Container Registry (GHCR) as an OCI registry alongside Docker Hub, addressing issue #393.
Changes Made
https://ghcr.io) as a supported OCI registryTesting
Breaking Changes
None - all existing packages continue to work unchanged.
Future Benefits
This refactoring makes it much easier to add additional OCI registries in the future (e.g., Quay.io, GCR, ACR) by simply adding entries to the registry configuration map.
Files Changed
pkg/model/constants.go- Added GHCR URL constantinternal/validators/registries/oci.go- Refactored with registry configuration systeminternal/validators/registries/oci_test.go- Added comprehensive testsdocs/reference/server-json/official-registry-requirements.md- Updated supported registriesCloses #393