fix: fix missing seed.json on startup by renaming file #75
Conversation
|
Hi @chenmingyong0423 , why not simply rename the |
|
@yshngg The current seed file is named seed_2025_05_16.json, and I wasn’t sure if there’s a specific versioning or naming convention behind it. To avoid unintentionally breaking that design decision, I chose to update the config and Docker setup to match the existing file rather than renaming it to seed.json. |
|
@chenmingyong0423 I understand your point, but I think this PR might reduce flexibility. The current seed file is named If we don't create new seed files, what's the difference between filenames |
|
@yshngg I actually agree that renaming seed_2025_05_16.json to seed.json would be a cleaner and simpler solution. However, I'm not sure if there was any specific reason or versioning intent behind the original filename. If not, standardizing it as seed.json makes perfect sense. Looking forward to hearing the maintainers’ thoughts. |
|
@yshngg I'd like to check — are you the main reviewer or maintainer of this project? If so, I’m happy to adjust the PR based on your suggestions. |
|
@yshngg It looks like you're the main reviewer or maintainer — I’ve updated the changes according to your suggestions. Thanks for the input! |
chenmingyong0423
changed the title
Oops, sorry for the confusion — I'm just interested in the project and not a reviewer or maintainer. |
Alright! |
chenmingyong0423
changed the title
|
This is actually nice. |
Co-authored-by: 陈明勇 <[email protected]>
domdomegg
force-pushed
the
feature/config
branch
from
b411a5e to
1122614
Compare
|
// rebasing on top of main... |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Renamed `data/seed_2025_05_16.json` to `data/seed.json` and updated `Dockerfile` ## Motivation and Context When cloning the repository and building the project using: ```bash go build ./cmd/registry .\\registry.exe ``` the application fails to start because the default seed file path (`data/seed.json`) does not exist in the repo: ``` Failed to read seed file: failed to read file: open data/seed.json: The system cannot find the file specified. ``` ## How Has This Been Tested? ```bash go build ./cmd/registry .\\registry.exe // ./registry ``` ## Breaking Changes None ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [x] I have read the [MCP Documentation](https://modelcontextprotocol.io) - [x] My code follows the repository's style guidelines - [x] New and existing tests pass locally - [ ] I have added appropriate error handling - [ ] I have added or updated documentation as needed Co-authored-by: Adam Jones <[email protected]>
5 participants
Renamed
data/seed_2025_05_16.jsontodata/seed.jsonand updatedDockerfileMotivation and Context
When cloning the repository and building the project using:
go build ./cmd/registry .\\registry.exethe application fails to start because the default seed file path (
data/seed.json) does not exist in the repo:How Has This Been Tested?
go build ./cmd/registry .\\registry.exe // ./registryBreaking Changes
None
Types of changes
Checklist
Additional context