Skip to content

Conversation

@4t145
Copy link
Collaborator

@4t145 4t145 commented Mar 7, 2025

Remove the dependency async-trait, for issue #20

Motivation and Context

How Has This Been Tested?

All the test passed

Breaking Changes

Exsited code need to remove the dependency async-trait and make their future return value Send.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@cbrit
Copy link

cbrit commented Mar 18, 2025

@4t145 Could you fix the linter/test errors?

@4t145
Copy link
Collaborator Author

4t145 commented Mar 18, 2025

@4t145 Could you fix the linter/test errors?

I didn't realize that you may need to create boxed dyn client here. So this is not good to simply remove all #[async-trait]. Maybe we should rethink about this pr?

@4t145
Copy link
Collaborator Author

4t145 commented Mar 18, 2025

I would like to close this pr temporarily, and discussions can be continued on #20.

@4t145 4t145 closed this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants