-
Notifications
You must be signed in to change notification settings - Fork 299
fix: make stdio shutdown more graceful #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8159d42
to
da87299
Compare
I'm not sure if adding a shutdown interface is necessary, although it may increase some flexibility for the caller, it may be redundant for the SDK. For me, the previous direct killing behavior was not very elegant, and I would like to hear more opinions.How about you ? |
I prefer to have a easier approch to cleanup in drop, and give user more flexibility in another explicit method. Or maybe we can just provide an into_inner method so the user can do anything they like with inner process. We can also wrap this wait-and-kill approch into a method, just as @crepererum metioned. |
Approve , I will change it. |
How about expose the transport in running service? @4t145 |
@jokemanfire Just have a look on the original issue
|
According to the protocol specifications Signed-off-by: jokemanfire <[email protected]>
@4t145 @crepererum Have a look , and pls check. |
According to the protocol specifications
Motivation and Context
Make shutdown more graceful.
How Has This Been Tested?
Ut
Breaking Changes
No breaking change
Types of changes
Checklist
Additional context