-
Notifications
You must be signed in to change notification settings - Fork 382
fix(oauth): rfc8414 should judement the response_types #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
response_types_supported |
pub issuer: Option<String>, | ||
pub jwks_uri: Option<String>, | ||
pub scopes_supported: Option<Vec<String>>, | ||
pub response_types_supported: Option<Vec<String>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the option here be removed for compatibility with rfc8414?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements RFC 8414 compliance by adding validation for the response_types_supported
field in OAuth 2.0 authorization server metadata to ensure servers support the "code" response type used in Authorization Code Flow.
- Adds
response_types_supported
field toAuthorizationMetadata
struct - Implements validation in both registration and authorization flows to check for "code" support
- Updates example server to include the required field and simplifies metadata creation using
Default
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
crates/rmcp/src/transport/auth.rs | Adds response_types_supported field and validation logic for RFC 8414 compliance |
examples/servers/src/complex_auth_sse.rs | Updates example server to include response_types_supported field |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
response_types_supported should be judement while try to do 'Authorization Code Flow' Signed-off-by: jokemanfire <[email protected]>
response_types_supported should be judement while try to do 'Authorization Code Flow'
Motivation and Context
according to rfc8414
How Has This Been Tested?
No
Breaking Changes
auth server should be more standardized.
Types of changes
Checklist
Additional context