Don't treat non-success HTTP codes as transport errors #486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec states that:
But the rust-sdk treated any POST responses with non successful status as an error.
Before this patch, trying to call list_resources on a server that does return HTTP 400 with JSON-RPC error:
After this patch:
Motivation and Context
Clients should be able to see the error the server sends. The code already checks for JSON content type, I assume the error_for_status for included by accident.
How Has This Been Tested?
Tests still seem to pass, but I did not add a new one. For testing, I created a demo client, but someone with more knowledge of the code should add a proper test case.
Breaking Changes
Could be seen as a breaking change if people relied on getting the transport error.
Types of changes
Checklist
Additional context