fix(oauth): three oauth discovery and registration issues #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
T-core
gpeal
commented
Oct 18, 2025
| pub client_id: String, | ||
| pub client_secret: Option<String>, | ||
| pub client_name: String, | ||
| pub client_name: Option<String>, |
There was a problem hiding this comment.
It is recommended but not required to send client_name
https://datatracker.ietf.org/doc/html/rfc7591
gpeal
commented
Oct 18, 2025
| Ok(None) | ||
| } | ||
|
|
||
| async fn fetch_resource_metadata_url(&self) -> Result<Option<Url>, AuthError> { |
There was a problem hiding this comment.
gpeal
force-pushed
the
gpeal/www-authenticate-header
branch
from
ce3df3a to
73d4574
Compare
gpeal
commented
Oct 18, 2025
| Ok(token) => token, | ||
| Err(RequestTokenError::Parse(_, body)) => { | ||
| match serde_json::from_slice::<OAuthTokenResponse>(&body) { | ||
| Ok(parsed) => { |
There was a problem hiding this comment.
Parse errors can happen during successful token exchanges
https://github.com/ramosbugs/oauth2-rs/blob/main/src/error.rs#L125
gpeal
force-pushed
the
gpeal/www-authenticate-header
branch
from
73d4574 to
8704262
Compare
gpeal
force-pushed
the
gpeal/www-authenticate-header
branch
from
8704262 to
a415b2e
Compare
gpeal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
While trying to get Supabase to login as part of openai/codex#5254, I encountered three separate oauth issues. Comments are inline
How Has This Been Tested?
Logged in to the Supabase MCP with Codex for the first time.
Sanity checked Linear, Notion, and Todoist and verified that they all still work.
Breaking Changes
None
Types of changes
Checklist