Skip to content

Conversation

@bruno-t-cardoso
Copy link

@bruno-t-cardoso bruno-t-cardoso commented Nov 7, 2025

Description

Fixed the Dockerfile for the sequential-thinking MCP server to properly compile TypeScript code during the Docker build process.

Server Details

  • Server: sequential-thinking
  • Changes to: Dockerfile build process

Motivation and Context

The original Dockerfile had a bug that prevented the TypeScript code from being compiled to JavaScript during the Docker build. Line 10 was running npm ci --ignore-scripts --omit-dev, which skipped the prepare script that triggers the build. This resulted in a Docker image that appeared to build successfully but was non-functional because the dist directory was missing.

This fix ensures the TypeScript code is properly compiled by explicitly running npm run build after installing dependencies.

How Has This Been Tested?

  • Built the Docker image using: docker build -t mcp/sequentialthinking -f src/sequentialthinking/Dockerfile .
  • Tested MCP protocol communication with: echo '{"jsonrpc":"2.0","id":1,"method":"initialize","params":{"protocolVersion":"2024-11-05","capabilities":{},"clientInfo":{"name":"test","version":"1.0"}}}' | docker run --rm -i mcp/sequentialthinking
  • Verified the server responds correctly to initialize and tools/list requests
  • Tested with Augment Code MCP client configuration

Breaking Changes

No breaking changes. Users with the previous broken Docker image will need to rebuild it, but the configuration remains the same.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Protocol Documentation
  • My changes follows MCP security best practices
  • I have updated the server's README accordingly
  • I have tested this with an LLM client
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have documented all environment variables and configuration options

Additional context

Before: The Dockerfile ran npm ci --ignore-scripts --omit-dev which prevented the TypeScript compilation.

After: The Dockerfile now explicitly runs npm run build to compile TypeScript to JavaScript, ensuring the dist directory is created and the Docker image is functional.

This fix makes the Docker installation method documented in the README actually work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant