fix: React to upstream RC schema changes for form mode elicitation requests #1154
+91
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
nbarbettini
commented
Nov 21, 2025
nbarbettini
changed the title
KKonstantinov
approved these changes
Nov 22, 2025
Contributor
|
LGTM! One comment is on the cherry picked spec types, but we probably have no choice and it will be just temporary until the tasks SEP gets finalized on TS SDK and merged. |
felixweinberger
approved these changes
Nov 23, 2025
Contributor
|
Thanks for updating the PR! Please merge at your convenience :) |
Contributor
|
Copied this branch at #1164 to make the release as permissions on this PR prevent me from merging it directly. |
Contributor
|
Closing in favor of #1164 which is a direct copy of this branch to allow merging. |
auto-merge was automatically disabled
November 25, 2025 11:21
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Reacting to upstream schema changes. Discussion: modelcontextprotocol/modelcontextprotocol#1863 (comment)
How Has This Been Tested?
Existing test coverage plus 1 new test.
Breaking Changes
None.
Types of changes
Checklist
Additional context
A few review comments inline, below.