-
Notifications
You must be signed in to change notification settings - Fork 1.6k
test(core): add unit tests for normalizeHeaders and createFetchWithInit #1374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
k61b
wants to merge
3
commits into
modelcontextprotocol:main
Choose a base branch
from
k61b:test/transport-utilities
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+182
−0
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,182 @@ | ||
| import { createFetchWithInit, type FetchLike, normalizeHeaders } from '../../src/shared/transport.js'; | ||
|
|
||
| describe('normalizeHeaders', () => { | ||
| test('returns empty object for undefined', () => { | ||
k61b marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| expect(normalizeHeaders(undefined)).toEqual({}); | ||
| }); | ||
|
|
||
| test('handles Headers instance', () => { | ||
| const headers = new Headers({ | ||
| 'x-foo': 'bar', | ||
| 'content-type': 'application/json' | ||
| }); | ||
| expect(normalizeHeaders(headers)).toEqual({ | ||
| 'x-foo': 'bar', | ||
| 'content-type': 'application/json' | ||
| }); | ||
| }); | ||
|
|
||
| test('handles array of tuples', () => { | ||
| const headers: [string, string][] = [ | ||
| ['x-foo', 'bar'], | ||
| ['x-baz', 'qux'] | ||
| ]; | ||
| expect(normalizeHeaders(headers)).toEqual({ | ||
| 'x-foo': 'bar', | ||
| 'x-baz': 'qux' | ||
| }); | ||
| }); | ||
|
|
||
| test('handles plain object', () => { | ||
| const headers = { 'x-foo': 'bar', 'x-baz': 'qux' }; | ||
| expect(normalizeHeaders(headers)).toEqual({ | ||
| 'x-foo': 'bar', | ||
| 'x-baz': 'qux' | ||
| }); | ||
| }); | ||
|
|
||
| test('returns a shallow copy for plain objects', () => { | ||
| const headers = { 'x-foo': 'bar' }; | ||
| const result = normalizeHeaders(headers); | ||
| expect(result).not.toBe(headers); | ||
| expect(result).toEqual(headers); | ||
| }); | ||
| }); | ||
k61b marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| describe('createFetchWithInit', () => { | ||
| test('returns baseFetch unchanged when no baseInit provided', () => { | ||
| const mockFetch: FetchLike = vi.fn(); | ||
| const result = createFetchWithInit(mockFetch); | ||
| expect(result).toBe(mockFetch); | ||
| }); | ||
|
|
||
| test('passes baseInit to fetch when no call init provided', async () => { | ||
| const mockFetch: FetchLike = vi.fn(); | ||
| const baseInit: RequestInit = { | ||
| method: 'POST', | ||
| credentials: 'include' | ||
| }; | ||
|
|
||
| const wrappedFetch = createFetchWithInit(mockFetch, baseInit); | ||
| await wrappedFetch('https://example.com'); | ||
|
|
||
| expect(mockFetch).toHaveBeenCalledWith( | ||
| 'https://example.com', | ||
| expect.objectContaining({ | ||
| method: 'POST', | ||
| credentials: 'include' | ||
| }) | ||
| ); | ||
| }); | ||
k61b marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| test('merges baseInit with call init, call init wins for non-header fields', async () => { | ||
| const mockFetch: FetchLike = vi.fn(); | ||
| const baseInit: RequestInit = { | ||
| method: 'POST', | ||
| credentials: 'include' | ||
| }; | ||
|
|
||
| const wrappedFetch = createFetchWithInit(mockFetch, baseInit); | ||
| await wrappedFetch('https://example.com', { method: 'PUT' }); | ||
|
|
||
| expect(mockFetch).toHaveBeenCalledWith( | ||
| 'https://example.com', | ||
| expect.objectContaining({ | ||
| method: 'PUT', | ||
| credentials: 'include' | ||
| }) | ||
| ); | ||
| }); | ||
k61b marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| test('merges headers from both base and call init', async () => { | ||
| const mockFetch: FetchLike = vi.fn(); | ||
| const baseInit: RequestInit = { | ||
| headers: { 'x-base': 'base-value', 'x-shared': 'base' } | ||
| }; | ||
|
|
||
| const wrappedFetch = createFetchWithInit(mockFetch, baseInit); | ||
| await wrappedFetch('https://example.com', { | ||
| headers: { 'x-call': 'call-value', 'x-shared': 'call' } | ||
| }); | ||
|
|
||
| expect(mockFetch).toHaveBeenCalledWith( | ||
| 'https://example.com', | ||
| expect.objectContaining({ | ||
| headers: { | ||
| 'x-base': 'base-value', | ||
| 'x-call': 'call-value', | ||
| 'x-shared': 'call' | ||
| } | ||
| }) | ||
| ); | ||
| }); | ||
k61b marked this conversation as resolved.
Show resolved
Hide resolved
k61b marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| test('uses baseInit headers when call init has no headers', async () => { | ||
| const mockFetch: FetchLike = vi.fn(); | ||
| const baseInit: RequestInit = { | ||
| headers: { 'x-base': 'base-value' } | ||
| }; | ||
|
|
||
| const wrappedFetch = createFetchWithInit(mockFetch, baseInit); | ||
| await wrappedFetch('https://example.com', { method: 'POST' }); | ||
|
|
||
| expect(mockFetch).toHaveBeenCalledWith( | ||
| 'https://example.com', | ||
| expect.objectContaining({ | ||
| method: 'POST', | ||
| headers: { 'x-base': 'base-value' } | ||
| }) | ||
| ); | ||
| }); | ||
k61b marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| test('handles URL object as first argument', async () => { | ||
| const mockFetch: FetchLike = vi.fn(); | ||
| const baseInit: RequestInit = { method: 'GET' }; | ||
|
|
||
| const wrappedFetch = createFetchWithInit(mockFetch, baseInit); | ||
| const url = new URL('https://example.com/path'); | ||
| await wrappedFetch(url); | ||
|
|
||
| expect(mockFetch).toHaveBeenCalledWith(url, expect.objectContaining({ method: 'GET' })); | ||
| }); | ||
|
|
||
| test('passes all baseInit properties when call init is empty object', async () => { | ||
| const mockFetch: FetchLike = vi.fn(); | ||
| const baseInit: RequestInit = { | ||
| method: 'POST', | ||
| credentials: 'include', | ||
| headers: { 'x-base': 'value' } | ||
| }; | ||
|
|
||
| const wrappedFetch = createFetchWithInit(mockFetch, baseInit); | ||
| await wrappedFetch('https://example.com', {}); | ||
|
|
||
| expect(mockFetch).toHaveBeenCalledWith( | ||
| 'https://example.com', | ||
| expect.objectContaining({ | ||
| method: 'POST', | ||
| credentials: 'include', | ||
| headers: { 'x-base': 'value' } | ||
| }) | ||
| ); | ||
| }); | ||
|
|
||
| test('passes Headers instance through when call init has no headers', async () => { | ||
| const mockFetch: FetchLike = vi.fn(); | ||
| const baseHeaders = new Headers({ 'x-base': 'value' }); | ||
| const baseInit: RequestInit = { | ||
| headers: baseHeaders | ||
| }; | ||
|
|
||
| const wrappedFetch = createFetchWithInit(mockFetch, baseInit); | ||
| await wrappedFetch('https://example.com', { method: 'POST' }); | ||
|
|
||
| expect(mockFetch).toHaveBeenCalledWith( | ||
| 'https://example.com', | ||
| expect.objectContaining({ | ||
| method: 'POST', | ||
| headers: baseHeaders | ||
| }) | ||
| ); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.