fix: resume in-memory event streams with underscored ids#1984
Open
Genmin wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix: resume in-memory event streams with underscored ids#1984Genmin wants to merge 2 commits intomodelcontextprotocol:mainfrom
Genmin wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 991ad4a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
8547223 to
3c4709e
Compare
Author
|
Added the missing patch changeset for the touched example/integration packages. The previous red test was isolated to the unrelated Miniflare Cloudflare Worker |
3753b16 to
991ad4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_GET_streamcan resume correctly_GET_streamevents and verifies replay after the first event returns the original stream id and sends the second eventFixes #943.
Validation
pnpm --filter @modelcontextprotocol/server test -- test/integration/test/taskResumability.test.ts -t "standalone SSE stream IDs"pnpm --filter @modelcontextprotocol/test-integration test -- test/taskResumability.test.ts -t "standalone SSE stream IDs"pnpm --filter @modelcontextprotocol/examples-server typecheckpnpm --filter @modelcontextprotocol/examples-server lintpnpm --filter @modelcontextprotocol/test-integration linttypecheck:all,build:all, andlint:all