fix: preserve exact resource URI from protected resource metadata#1991
Open
Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: preserve exact resource URI from protected resource metadata#1991Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Christian-Sidak wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
…alization When protected resource metadata contains a pathless URI like "https://example.com", the SDK was normalizing it to "https://example.com/" via URL.href. This broke OAuth with providers like Microsoft Entra ID that require the resource parameter to exactly match the scopes' audience. Change selectResourceURL to return the original metadata string directly instead of wrapping it in new URL(), and update all serialization sites to use String() instead of .href so URL objects are still handled correctly. Fixes modelcontextprotocol#1968 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 60993b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selectResourceURL()was returningnew URL(resourceMetadata.resource), which normalizes pathless URIs likehttps://example.comtohttps://example.com/viaURL.href.href, further cementing the trailing slashselectResourceURL()to return the original metadata string directly (preserving the exact value), and updated all serialization to useString(resource)instead ofresource.hrefselectResourceURLand theresourceparameter instartAuthorization,executeTokenRequest,exchangeAuthorization,refreshAuthorization, andfetchTokenfromURLtoURL | stringto accommodate both metadata strings and customvalidateResourceURLURL objectsTest plan
preserves pathless resource URI from PRM without adding trailing slashnew URL("https://example.com").href === "https://example.com/"(the bug), and that returning the string directly preserves"https://example.com"Fixes #1968