fix(server): surface stateless transport reuse errors#1995
Open
Genmin wants to merge 1 commit intomodelcontextprotocol:v1.xfrom
Open
fix(server): surface stateless transport reuse errors#1995Genmin wants to merge 1 commit intomodelcontextprotocol:v1.xfrom
Genmin wants to merge 1 commit intomodelcontextprotocol:v1.xfrom
Conversation
🦋 Changeset detectedLatest commit: 0c3595b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transport.onerrorfor that reuse error instead of letting the exception become an opaque Hono 500Context
Addresses the visibility and diagnostics part of #1994. The existing v1.x code intentionally guards against reusing a stateless transport instance; this PR keeps that lifecycle rule, but makes the failure observable and parseable. That turns the current empty/text 500 into the SDK's normal JSON-RPC error shape and calls
onerrorwith the underlying error message.Validation
npx vitest run test/server/streamableHttp.test.ts -t "should return a JSON error when a stateless transport is reused with a pre-parsed body"npx vitest run test/server/streamableHttp.test.ts -t "should call onerror and return JSON when stateless transport is reused"npx vitest run test/server/streamableHttp.test.tsnpm run typecheck -- --pretty falsenpx prettier --check src/server/streamableHttp.ts src/server/webStandardStreamableHttp.ts test/server/streamableHttp.test.ts .changeset/stateless-transport-reuse-error.mdgit diff --check