fix(server): allow JSON Accept in JSON response mode#1996
Open
Genmin wants to merge 1 commit intomodelcontextprotocol:v1.xfrom
Open
fix(server): allow JSON Accept in JSON response mode#1996Genmin wants to merge 1 commit intomodelcontextprotocol:v1.xfrom
Genmin wants to merge 1 commit intomodelcontextprotocol:v1.xfrom
Conversation
🦋 Changeset detectedLatest commit: 3b37516 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accept: application/jsonwithout also requiringtext/event-stream*/*through a small Accept parser instead of substring-only checksapplication/json+text/event-streamrequirement for SSE response modeContext
Fixes #1944. When
enableJsonResponse: true, POST requests resolve to plain JSON responses and never open the SSE stream path, so requiring clients to advertisetext/event-streamrejects valid JSON-RPC-over-HTTP clients.Validation
npx vitest run test/server/streamableHttp.test.ts -t "JSON response mode"npx vitest run test/server/streamableHttp.test.ts -t "application/json-only Accept"npx vitest run test/server/streamableHttp.test.tsnpm run typecheck -- --pretty falsenpx prettier --check src/server/webStandardStreamableHttp.ts test/server/streamableHttp.test.ts .changeset/json-accept-json-response.mdgit diff --check