fix: preserve elicit string pattern constraints#1999
Open
Genmin wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: preserve elicit string pattern constraints#1999Genmin wants to merge 1 commit intomodelcontextprotocol:mainfrom
Genmin wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 34e7438 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
04a193d to
34e7438
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
patternon elicitation string property schemas instead of stripping it during validation.StringSchemaSchemaparsing and nestedElicitRequestFormParamsSchemaparsing.StringSchema.pattern, whilespec.types.tsis still missing it.Notes
This intentionally keeps the change narrow to the spec-backed string
patternfield rather than making all primitive schemas permissive. It addresses the concretepatternloss described in #1844 without broad passthrough behavior.Spec reference: https://modelcontextprotocol.io/specification/2025-11-25/client/elicitation
Validation
pnpm --filter @modelcontextprotocol/core exec vitest run test/types.test.ts test/spec.types.test.tspnpm --filter @modelcontextprotocol/core run typecheckpnpm --filter @modelcontextprotocol/core exec prettier --ignore-path ../../.prettierignore --check src/types/schemas.ts test/types.test.ts test/spec.types.test.tspnpm -r typecheck,pnpm -r build,pnpm sync:snippets --check && pnpm -r lint