fix schema definitions for RequestSchema #20
Merged
+2,881
−568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pizzaface
pushed a commit
to RewstApp/mcp-inspector
that referenced
this pull request
May 2, 2025
7d70db8 Merge pull request modelcontextprotocol#20 from modelcontextprotocol/ashwin/progress 65a8613 fix schema definitions for RequestSchema git-subtree-dir: packages/mcp-typescript git-subtree-split: 7d70db8
Pizzaface
pushed a commit
to RewstApp/mcp-inspector
that referenced
this pull request
May 2, 2025
…ashwin/ping Add ping tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out Zod's
.extenddoesn't do a deep merge on fields, it's really just for adding/replacing fields. So in order for all requests to have the_meta.progressTokenfield, we need to explicitly extend theparamsfield wherever we're adding params.