-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: implement MCP-Protocol-Version header requirement for HTTP transport #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
84971c8
Set Mcp-Protocol-Version in client requests after init, and warn when…
ochafik 18f8b40
Merge branch 'main' into ochafik/protocol-version
ochafik bb0592b
add supported versions to error message
ochafik a28e25a
use const in test
ochafik e573a0f
nits: remove dead comment & align test style on local idioms
ochafik 4e9d6a7
Merge branch 'ochafik/protocol-version' of https://github.com/modelco…
ochafik 4aaa26d
remove protocol version mismatch warning
ochafik 33257f1
switch to optional Transport.setProtocolVersion
ochafik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,6 +62,7 @@ export class SSEClientTransport implements Transport { | |
private _eventSourceInit?: EventSourceInit; | ||
private _requestInit?: RequestInit; | ||
private _authProvider?: OAuthClientProvider; | ||
protocolVersion?: string; | ||
|
||
onclose?: () => void; | ||
onerror?: (error: Error) => void; | ||
|
@@ -99,13 +100,18 @@ export class SSEClientTransport implements Transport { | |
} | ||
|
||
private async _commonHeaders(): Promise<HeadersInit> { | ||
const headers: HeadersInit = { ...this._requestInit?.headers }; | ||
const headers = { | ||
...this._requestInit?.headers, | ||
} as HeadersInit & Record<string, string>; | ||
if (this._authProvider) { | ||
const tokens = await this._authProvider.tokens(); | ||
if (tokens) { | ||
(headers as Record<string, string>)["Authorization"] = `Bearer ${tokens.access_token}`; | ||
headers["Authorization"] = `Bearer ${tokens.access_token}`; | ||
} | ||
} | ||
if (this.protocolVersion) { | ||
headers["mcp-protocol-version"] = this.protocolVersion; | ||
} | ||
|
||
return headers; | ||
} | ||
|
@@ -214,7 +220,9 @@ export class SSEClientTransport implements Transport { | |
|
||
try { | ||
const commonHeaders = await this._commonHeaders(); | ||
const headers = new Headers({ ...commonHeaders, ...this._requestInit?.headers }); | ||
// Note: this._requestInit?.headers already set in _commonHeaders | ||
// const headers = new Headers({ ...commonHeaders, ...this._requestInit?.headers }); | ||
|
||
const headers = new Headers(commonHeaders); | ||
headers.set("content-type", "application/json"); | ||
const init = { | ||
...this._requestInit, | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer not to set the property directly, instead, expose
setProtocolVersion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added setProtocolVersion (optional to avoid having to implement it in all transports - incl. test transports)