Skip to content

Use detached: true on Windows #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Use detached: true on Windows #62

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17a32b1
Use detached: true on Windows
anaisbetts Nov 20, 2024
e0c821c
Special-case this fix to Electron apps
anaisbetts Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/client/stdio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ export class StdioClientTransport implements Transport {
env: this._serverParams.env ?? getDefaultEnvironment(),
stdio: ["pipe", "pipe", this._serverParams.stderr ?? "inherit"],
shell: false,
detached: process.platform === "win32",
signal: this._abortController.signal,
},
);
Expand Down