Skip to content

feature: add configuration option for shell of stdio client #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feature: add configuration option for shell of stdio client #977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/client/stdio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ export type StdioServerParameters = {
*/
args?: string[];

/**
* Whether to use a shell to execute the command, or the shell to use.
*
* If not specified, the default is false.
*/
shell?: string | boolean;

/**
* The environment to use when spawning the process.
*
Expand Down Expand Up @@ -125,7 +132,7 @@ export class StdioClientTransport implements Transport {
...this._serverParams.env
},
stdio: ['pipe', 'pipe', this._serverParams.stderr ?? 'inherit'],
shell: false,
shell: this._serverParams.shell ?? false,
signal: this._abortController.signal,
windowsHide: process.platform === 'win32' && isElectron(),
cwd: this._serverParams.cwd
Expand Down