Skip to content

fix: change Icon.sizes from string to string[] #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2025
+5 −3
Merged

fix: change Icon.sizes from string to string[] #981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/examples/server/simpleStreamableHttp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const getServer = () => {
const server = new McpServer({
name: 'simple-streamable-http-server',
version: '1.0.0',
icons: [{src: './mcp.svg', sizes: '512x512', mimeType: 'image/svg+xml'}],
icons: [{src: './mcp.svg', sizes: ['512x512'], mimeType: 'image/svg+xml'}],
websiteUrl: 'https://github.com/modelcontextprotocol/typescript-sdk',
}, { capabilities: { logging: {} } });

Expand Down
6 changes: 4 additions & 2 deletions src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,9 +214,11 @@ export const IconSchema = z
*/
mimeType: z.optional(z.string()),
/**
* Optional string specifying icon dimensions (e.g., "48x48 96x96").
* Optional array of strings that specify sizes at which the icon can be used.
* Each string should be in WxH format (e.g., "48x48", "96x96") or "any" for scalable formats like SVG.
* If not provided, the client should assume that the icon can be used at any size.
*/
sizes: z.optional(z.string()),
sizes: z.optional(z.array(z.string())),
})
.passthrough();

Expand Down