chore: fix ESLint errors and warnings

Oleksandr Dzhychko · Oleksandr Dzhychko · commit 0b2b2c534b4e · 2024-09-19T09:22:22.000+02:00
diff --git a/model-api-gen-gradle-test/typescript-generation/src/ChildrenAccessor.test.ts b/model-api-gen-gradle-test/typescript-generation/src/ChildrenAccessor.test.ts
@@ -4,8 +4,9 @@
  * of the generated languages, we will conduct the test here for now.
  */
 
+import type {
+  BaseCommentAttribute} from "../build/typescript_src/L_jetbrains_mps_lang_core";
 import {
-  BaseCommentAttribute,
   C_BaseCommentAttribute,
   C_BaseConcept,
   C_TypeAnnotated,
diff --git a/model-api-gen-gradle-test/typescript-generation/src/test-helpers.ts b/model-api-gen-gradle-test/typescript-generation/src/test-helpers.ts
@@ -1,5 +1,6 @@
 import { org } from "@modelix/model-client";
-import { ITypedNode, LanguageRegistry } from "@modelix/ts-model-api";
+import type { ITypedNode} from "@modelix/ts-model-api";
+import { LanguageRegistry } from "@modelix/ts-model-api";
 import { registerLanguages } from "../build/typescript_src";
 
 const DEFAULT_NODE_DATA = {
diff --git a/model-api-gen-gradle-test/vue-integration/src/intergration.test.ts b/model-api-gen-gradle-test/vue-integration/src/intergration.test.ts
@@ -1,18 +1,18 @@
 import { useModelsFromJson } from "@modelix/vue-model-api";
 import { computed } from "vue";
 import { registerLanguages } from "typescript-generation";
+import type { BaseConcept } from "typescript-generation/dist/L_jetbrains_mps_lang_core";
 import {
-  BaseConcept,
   C_Attribute,
   C_INamedConcept,
   isOfConcept_INamedConcept,
 } from "typescript-generation/dist/L_jetbrains_mps_lang_core";
-import {
+import type {
   StaticFieldReference,
   Classifier,
 } from "typescript-generation/dist/L_jetbrains_mps_baseLanguage";
 
-import { ITypedNode, LanguageRegistry } from "@modelix/ts-model-api";
+import { LanguageRegistry } from "@modelix/ts-model-api";
 
 registerLanguages();
 
diff --git a/model-server/src/main/resources/public/content-explorer.js b/model-server/src/main/resources/public/content-explorer.js
@@ -11,6 +11,7 @@ function getExpandedNodeIds() {
         element => element.nextElementSibling?.getAttribute('data-nodeid'));
 }
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars -- Used by HTML generated in Kotlin
 function scrollToElement(id) {
     document.getElementById(id).scrollIntoView();
 }
diff --git a/ts-model-api/src/ILanguage.ts b/ts-model-api/src/ILanguage.ts
@@ -1,4 +1,4 @@
-
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type -- Use empty interface to generate an interface in Kotlin.
 export interface ILanguage {
 
 }
diff --git a/ts-model-api/src/INodeJS.ts b/ts-model-api/src/INodeJS.ts
@@ -27,5 +27,5 @@ export interface INodeJS {
   setPropertyValue(role: string, value: string | undefined): void
 }
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any,@typescript-eslint/no-unused-vars -- Keep for backward compatibility
+// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Keep for backward compatibility
 type INodeReferenceJS = any
diff --git a/ts-model-api/src/TSModelClient.ts b/ts-model-api/src/TSModelClient.ts
@@ -179,11 +179,11 @@ interface VersionData {
 
 interface NodeData {
   nodeId: NodeId,
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any,@typescript-eslint/no-unused-vars -- Keep for backward compatibility
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any -- Keep for backward compatibility
   references: any,
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any,@typescript-eslint/no-unused-vars -- Keep for backward compatibility
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any -- Keep for backward compatibility
   properties: any,
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any,@typescript-eslint/no-unused-vars -- Keep for backward compatibility
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any -- Keep for backward compatibility
   children: any
 }
 
@@ -193,11 +193,11 @@ interface NodeUpdateData {
   role: string | undefined,
   index: number | undefined,
   concept: string | undefined,
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any,@typescript-eslint/no-unused-vars -- Keep for backward compatibility
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any -- Keep for backward compatibility
   references: any,
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any,@typescript-eslint/no-unused-vars -- Keep for backward compatibility
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any -- Keep for backward compatibility
   properties: any,
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any,@typescript-eslint/no-unused-vars -- Keep for backward compatibility
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any -- Keep for backward compatibility
   children: any
 }
 
diff --git a/vue-model-api/src/internal/Cache.test.ts b/vue-model-api/src/internal/Cache.test.ts
@@ -1,4 +1,4 @@
-import { INodeJS } from "@modelix/ts-model-api";
+import type { INodeJS } from "@modelix/ts-model-api";
 import { Cache } from "./Cache";
 
 test("wrapper is added to cache", () => {
diff --git a/vue-model-api/src/internal/Cache.ts b/vue-model-api/src/internal/Cache.ts
@@ -1,6 +1,6 @@
 // The cache could be made independent from INodeJS. Currently this is not needed.
 // The cache is a implemenation detail and can be refactored when needed for reuse.
-import { INodeJS } from "@modelix/ts-model-api";
+import type { INodeJS } from "@modelix/ts-model-api";
 
 /**
  * Cache for memoizing values assoziated with {@link INodeJS}.
diff --git a/vue-model-api/src/internal/ReactiveINodeJS.ts b/vue-model-api/src/internal/ReactiveINodeJS.ts
@@ -1,6 +1,6 @@
-import { IConceptJS, INodeJS } from "@modelix/ts-model-api";
+import type { IConceptJS, INodeJS } from "@modelix/ts-model-api";
 import { customRef, markRaw } from "vue";
-import { Cache } from "./Cache";
+import type { Cache } from "./Cache";
 
 export function toReactiveINodeJS(
   node: INodeJS,
diff --git a/vue-model-api/src/internal/handleChange.ts b/vue-model-api/src/internal/handleChange.ts
@@ -1,6 +1,6 @@
 import { org } from "@modelix/model-client";
-import { ReactiveINodeJS } from "./ReactiveINodeJS";
-import { Cache } from "./Cache";
+import type { ReactiveINodeJS } from "./ReactiveINodeJS";
+import type { Cache } from "./Cache";
 
 const { PropertyChanged, ReferenceChanged, ChildrenChanged } =
   org.modelix.model.client2;
diff --git a/vue-model-api/src/useModelClient.ts b/vue-model-api/src/useModelClient.ts
@@ -1,4 +1,5 @@
-import { MaybeRefOrGetter, Ref, shallowRef, toValue } from "vue";
+import type { MaybeRefOrGetter, Ref } from "vue";
+import { shallowRef, toValue } from "vue";
 import { useLastPromiseEffect } from "./internal/useLastPromiseEffect";
 import { org } from "@modelix/model-client";
 
diff --git a/vue-model-api/src/useModelsFromJson.ts b/vue-model-api/src/useModelsFromJson.ts
@@ -1,5 +1,6 @@
-import { INodeJS } from "@modelix/ts-model-api";
-import { ReactiveINodeJS, toReactiveINodeJS } from "./internal/ReactiveINodeJS";
+import type { INodeJS } from "@modelix/ts-model-api";
+import type { ReactiveINodeJS } from "./internal/ReactiveINodeJS";
+import { toReactiveINodeJS } from "./internal/ReactiveINodeJS";
 import { Cache } from "./internal/Cache";
 import { handleChange } from "./internal/handleChange";
 import { org } from "@modelix/model-client";
diff --git a/vue-model-api/src/useReplicatedModel.test.ts b/vue-model-api/src/useReplicatedModel.test.ts
@@ -1,5 +1,5 @@
 import { org } from "@modelix/model-client";
-import { INodeJS } from "@modelix/ts-model-api";
+import type { INodeJS } from "@modelix/ts-model-api";
 import { watchEffect } from "vue";
 import { useModelClient } from "./useModelClient";
 import { useReplicatedModel } from "./useReplicatedModel";
diff --git a/vue-model-api/src/useReplicatedModel.ts b/vue-model-api/src/useReplicatedModel.ts
@@ -1,8 +1,10 @@
-import { org } from "@modelix/model-client";
-import { INodeJS } from "@modelix/ts-model-api";
+import type { org } from "@modelix/model-client";
+import type { INodeJS } from "@modelix/ts-model-api";
 import { useLastPromiseEffect } from "./internal/useLastPromiseEffect";
-import { MaybeRefOrGetter, Ref, shallowRef, toValue } from "vue";
-import { ReactiveINodeJS, toReactiveINodeJS } from "./internal/ReactiveINodeJS";
+import type { MaybeRefOrGetter, Ref } from "vue";
+import { shallowRef, toValue } from "vue";
+import type { ReactiveINodeJS } from "./internal/ReactiveINodeJS";
+import { toReactiveINodeJS } from "./internal/ReactiveINodeJS";
 import { Cache } from "./internal/Cache";
 import { handleChange } from "./internal/handleChange";
 

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@ function getExpandedNodeIds() {`
`11`	`11`	`element => element.nextElementSibling?.getAttribute('data-nodeid'));`
`12`	`12`	`}`
`13`	`13`
	`14`	`+// eslint-disable-next-line @typescript-eslint/no-unused-vars -- Used by HTML generated in Kotlin`
`14`	`15`	`function scrollToElement(id) {`
`15`	`16`	`document.getElementById(id).scrollIntoView();`
`16`	`17`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-`
	`1`	`+// eslint-disable-next-line @typescript-eslint/no-empty-object-type -- Use empty interface to generate an interface in Kotlin.`
`2`	`2`	`export interface ILanguage {`
`3`	`3`
`4`	`4`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,5 +27,5 @@ export interface INodeJS {`
`27`	`27`	`setPropertyValue(role: string, value: string \| undefined): void`
`28`	`28`	`}`
`29`	`29`
`30`		`-// eslint-disable-next-line @typescript-eslint/no-explicit-any,@typescript-eslint/no-unused-vars -- Keep for backward compatibility`
	`30`	`+// eslint-disable-next-line @typescript-eslint/no-explicit-any -- Keep for backward compatibility`
`31`	`31`	`type INodeReferenceJS = any`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { INodeJS } from "@modelix/ts-model-api";`
	`1`	`+import type { INodeJS } from "@modelix/ts-model-api";`
`2`	`2`	`import { Cache } from "./Cache";`
`3`	`3`
`4`	`4`	`test("wrapper is added to cache", () => {`