Skip to content

New UI for permission management #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slisson merged 5 commits into from
Dec 19, 2024

chore(authorization): remove unused `deniedPermissionRequests`

5add048
Select commit
Loading
Failed to load commit list.
Merged

New UI for permission management #1269

chore(authorization): remove unused `deniedPermissionRequests`
5add048
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Advanced Security / detekt succeeded Dec 19, 2024 in 7s

29 new alerts

New alerts in code changed by this pull request

  • 29 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 92 in authorization/src/main/kotlin/org/modelix/authorization/AuthorizationPlugin.kt

See this annotation in the file changed.

Code scanning / detekt

Name shadowed: implicit lambda parameter 'it' Warning

Name shadowed: implicit lambda parameter 'it'

Check warning on line 94 in authorization/src/main/kotlin/org/modelix/authorization/AuthorizationPlugin.kt

See this annotation in the file changed.

Code scanning / detekt

Dispatcher IO is used without dependency injection. Warning

Dispatcher IO is used without dependency injection.

Check warning on line 68 in authorization/src/main/kotlin/org/modelix/authorization/PermissionManagementPage.kt

See this annotation in the file changed.

Code scanning / detekt

Name shadowed: implicit lambda parameter 'it' Warning

Name shadowed: implicit lambda parameter 'it'

Check warning on line 86 in authorization/src/main/kotlin/org/modelix/authorization/PermissionManagementPage.kt

See this annotation in the file changed.

Code scanning / detekt

Calling !! on a nullable type will throw a NullPointerException at runtime in case the value is null. It should be avoided. Warning

Calling !! on a nullable type will throw a NullPointerException at runtime in case the value is null. It should be avoided.

Check warning on line 91 in authorization/src/main/kotlin/org/modelix/authorization/PermissionManagementPage.kt

See this annotation in the file changed.

Code scanning / detekt

Name shadowed: implicit lambda parameter 'it' Warning

Name shadowed: implicit lambda parameter 'it'

Check warning on line 95 in authorization/src/main/kotlin/org/modelix/authorization/PermissionManagementPage.kt

See this annotation in the file changed.

Code scanning / detekt

Name shadowed: implicit lambda parameter 'it' Warning

Name shadowed: implicit lambda parameter 'it'

Check warning on line 96 in authorization/src/main/kotlin/org/modelix/authorization/PermissionManagementPage.kt

See this annotation in the file changed.

Code scanning / detekt

Name shadowed: implicit lambda parameter 'it' Warning

Name shadowed: implicit lambda parameter 'it'

Check warning on line 97 in authorization/src/main/kotlin/org/modelix/authorization/PermissionManagementPage.kt

See this annotation in the file changed.

Code scanning / detekt

Name shadowed: implicit lambda parameter 'it' Warning

Name shadowed: implicit lambda parameter 'it'

Check warning on line 150 in authorization/src/main/kotlin/org/modelix/authorization/PermissionManagementPage.kt

See this annotation in the file changed.

Code scanning / detekt

Name shadowed: resourceId Warning

Name shadowed: resourceId

Check warning on line 180 in authorization/src/main/kotlin/org/modelix/authorization/PermissionManagementPage.kt

See this annotation in the file changed.

Code scanning / detekt

This '?: emptySet()' can be replaced with 'orEmpty()' call Warning

This '?: emptySet()' can be replaced with 'orEmpty()' call

Check warning on line 181 in authorization/src/main/kotlin/org/modelix/authorization/PermissionManagementPage.kt

See this annotation in the file changed.

Code scanning / detekt

This '?: emptySet()' can be replaced with 'orEmpty()' call Warning

This '?: emptySet()' can be replaced with 'orEmpty()' call

Check warning on line 243 in authorization/src/main/kotlin/org/modelix/authorization/PermissionManagementPage.kt

See this annotation in the file changed.

Code scanning / detekt

Calling !! on a nullable type will throw a NullPointerException at runtime in case the value is null. It should be avoided. Warning

Calling !! on a nullable type will throw a NullPointerException at runtime in case the value is null. It should be avoided.

Check warning on line 279 in authorization/src/main/kotlin/org/modelix/authorization/PermissionManagementPage.kt

See this annotation in the file changed.

Code scanning / detekt

The function buildPermissionIncludesList is missing documentation. Warning

The function buildPermissionIncludesList is missing documentation.

Check warning on line 304 in authorization/src/main/kotlin/org/modelix/authorization/PermissionManagementPage.kt

See this annotation in the file changed.

Code scanning / detekt

Name shadowed: userId Warning

Name shadowed: userId

Check warning on line 305 in authorization/src/main/kotlin/org/modelix/authorization/PermissionManagementPage.kt

See this annotation in the file changed.

Code scanning / detekt

Name shadowed: roleId Warning

Name shadowed: roleId

Check warning on line 344 in authorization/src/main/kotlin/org/modelix/authorization/PermissionManagementPage.kt

See this annotation in the file changed.

Code scanning / detekt

The function canManagePermissions is missing documentation. Warning

The function canManagePermissions is missing documentation.

Check warning on line 374 in authorization/src/main/kotlin/org/modelix/authorization/PermissionManagementPage.kt

See this annotation in the file changed.

Code scanning / detekt

Name shadowed: implicit lambda parameter 'it' Warning

Name shadowed: implicit lambda parameter 'it'

Check warning on line 23 in authorization/src/main/kotlin/org/modelix/authorization/PermissionSchemaPage.kt

See this annotation in the file changed.

Code scanning / detekt

The function buildSchemaPage is missing documentation. Warning

The function buildSchemaPage is missing documentation.

Check warning on line 24 in authorization/src/main/kotlin/org/modelix/authorization/permissions/AccessControlData.kt

See this annotation in the file changed.

Code scanning / detekt

The property knownUsers is missing documentation. Warning

The property knownUsers is missing documentation.

Check warning on line 25 in authorization/src/main/kotlin/org/modelix/authorization/permissions/AccessControlData.kt

See this annotation in the file changed.

Code scanning / detekt

The property knownRoles is missing documentation. Warning

The property knownRoles is missing documentation.

Check warning on line 93 in authorization/src/main/kotlin/org/modelix/authorization/permissions/AccessControlData.kt

See this annotation in the file changed.

Code scanning / detekt

The function recordKnownUser is missing documentation. Warning

The function recordKnownUser is missing documentation.

Check warning on line 98 in authorization/src/main/kotlin/org/modelix/authorization/permissions/AccessControlData.kt

See this annotation in the file changed.

Code scanning / detekt

The function recordKnownUsers is missing documentation. Warning

The function recordKnownUsers is missing documentation.

Check warning on line 105 in authorization/src/main/kotlin/org/modelix/authorization/permissions/AccessControlData.kt

See this annotation in the file changed.

Code scanning / detekt

The function recordKnownRoles is missing documentation. Warning

The function recordKnownRoles is missing documentation.

Check warning on line 39 in authorization/src/main/kotlin/org/modelix/authorization/permissions/PermissionParser.kt

See this annotation in the file changed.

Code scanning / detekt

The function parseResource is missing documentation. Warning

The function parseResource is missing documentation.

Check warning on line 150 in authorization/src/main/kotlin/org/modelix/authorization/permissions/SchemaInstance.kt

See this annotation in the file changed.

Code scanning / detekt

The property fullId is missing documentation. Warning

The property fullId is missing documentation.