-
Notifications
You must be signed in to change notification settings - Fork 11
Draft: feat(metamodel-export): serialize annotations on concept nodes into the metamodel json #1877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Test Results 227 files 227 suites 44m 27s ⏱️ Results for commit 38e1ac1. ♻️ This comment has been updated with latest results. |
JVM coverage report
|
metamodel-export/src/main/kotlin/org/modelix/metamodel/export/MPSMetaModelExporter.kt
Fixed
Show fixed
Hide fixed
metamodel-export/src/main/kotlin/org/modelix/metamodel/export/MPSMetaModelExporter.kt
Fixed
Show fixed
Hide fixed
for (reference: SReference in node.references) { | ||
references[reference.link.name] = reference.targetNodeReference.toString() | ||
companion object { | ||
fun exportNode(node: SNode): NodeData { |
Check warning
Code scanning / detekt
The function exportNode is missing documentation. Warning
8adccd3
to
788c514
Compare
…he metamodel json
788c514
to
38e1ac1
Compare
val smodelAttribute: SContainmentLink = MetaAdapterFactory.getContainmentLink( | ||
-0x3154ae6ada15b0deL, | ||
-0x646defc46a3573f4L, | ||
0x10802efe25aL, |
Check warning
Code scanning / detekt
This expression contains a magic number. Consider defining it to a well named constant. Warning
-0x3154ae6ada15b0deL, | ||
-0x646defc46a3573f4L, | ||
0x10802efe25aL, | ||
0x47bf8397520e5942L, |
Check warning
Code scanning / detekt
This expression contains a magic number. Consider defining it to a well named constant. Warning
I would prefer representing the supported annotations as separate data classes instead of exporting them as NodeData. |
Changes