Draft: feat(metamodel-export): serialize annotations on concept nodes into the metamodel json #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

abstraktor wants to merge 1 commit into main from feature/export-concept-annotations

+70 −14

Collaborator

abstraktor commented Aug 19, 2025

Changes

feat(metamodel-export): serialize annotations on concept nodes into the metamodel json

Contributor

github-actions bot commented Aug 19, 2025 •

edited

Loading

Test Results

239 files 239 suites 51m 4s ⏱️
1 361 tests 1 350 ✅ 11 💤 0 ❌
1 371 runs 1 360 ✅ 11 💤 0 ❌

Results for commit cb6d8d6.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Aug 19, 2025 •

edited

Loading

JVM coverage report

Overall Project	58.79% `-0.26%`	❌
Files changed	1.78%	❌

File	Coverage
MetaModelData.kt	38.63% `-13.78%`	❌
MPSModelExporter.kt	0% `-29.73%`	❌
MPSMetaModelExporter.kt	0% `-10.24%`	❌

github-advanced-security bot found potential problems

View reviewed changes

metamodel-export/src/main/kotlin/org/modelix/metamodel/export/MPSMetaModelExporter.kt Fixed Show fixed Hide fixed

metamodel-export/src/main/kotlin/org/modelix/metamodel/export/MPSMetaModelExporter.kt Fixed Show fixed Hide fixed

metamodel-export/src/main/kotlin/org/modelix/metamodel/export/MPSModelExporter.kt

    
                      for (reference: SReference in node.references) {

                          references[reference.link.name] = reference.targetNodeReference.toString()

                  companion object {

                      fun exportNode(node: SNode): NodeData {

Check warning

Code scanning / detekt

The function exportNode is missing documentation. Warning

The function exportNode is missing documentation.

abstraktor force-pushed the feature/export-concept-annotations branch 2 times, most recently from 788c514 to 38e1ac1 Compare

August 20, 2025 08:46

github-advanced-security bot found potential problems

View reviewed changes

metamodel-export/src/main/kotlin/org/modelix/metamodel/export/MPSMetaModelExporter.kt

    
                      val smodelAttribute: SContainmentLink = MetaAdapterFactory.getContainmentLink(

                          -0x3154ae6ada15b0deL,

                          -0x646defc46a3573f4L,

                          0x10802efe25aL,

Check warning

Code scanning / detekt

This expression contains a magic number. Consider defining it to a well named constant. Warning

This expression contains a magic number. Consider defining it to a well named constant.

metamodel-export/src/main/kotlin/org/modelix/metamodel/export/MPSMetaModelExporter.kt

    
                          -0x3154ae6ada15b0deL,

                          -0x646defc46a3573f4L,

                          0x10802efe25aL,

                          0x47bf8397520e5942L,

Check warning

Code scanning / detekt

This expression contains a magic number. Consider defining it to a well named constant. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Member

slisson commented Aug 21, 2025

I would prefer representing the supported annotations as separate data classes instead of exporting them as NodeData.


          feat(metamodel-export): serialize annotations on concept nodes into t…

cb6d8d6

…he metamodel json

abstraktor force-pushed the feature/export-concept-annotations branch from 38e1ac1 to cb6d8d6 Compare

November 4, 2025 14:46

github-advanced-security bot found potential problems

View reviewed changes

metamodel-export/src/main/kotlin/org/modelix/metamodel/export/MPSMetaModelExporter.kt

    
                      jsonFile.writeText(languageData.toJson(), StandardCharsets.UTF_8)

                  }

                  fun exportAnnotation(node: SNode): AnnotationData =

Check warning

Code scanning / detekt

The function exportAnnotation is missing documentation. Warning

The function exportAnnotation is missing documentation.

metamodel-export/src/main/kotlin/org/modelix/metamodel/export/MPSMetaModelExporter.kt

    
                      )

                      val AttributeInfoConceptDeclaration: SConcept = MetaAdapterFactory.getConcept(

                          -4094437568663370681,

Check warning

Code scanning / detekt

This expression contains a magic number. Consider defining it to a well named constant. Warning

This expression contains a magic number. Consider defining it to a well named constant.

metamodel-export/src/main/kotlin/org/modelix/metamodel/export/MPSMetaModelExporter.kt

    
                      val AttributeInfoConceptDeclaration: SConcept = MetaAdapterFactory.getConcept(

                          -4094437568663370681,

                          -8968368868337559369,

Check warning

Code scanning / detekt

This expression contains a magic number. Consider defining it to a well named constant. Warning

This expression contains a magic number. Consider defining it to a well named constant.

metamodel-export/src/main/kotlin/org/modelix/metamodel/export/MPSMetaModelExporter.kt

    
                      val AttributeInfoConceptDeclaration: SConcept = MetaAdapterFactory.getConcept(

                          -4094437568663370681,

                          -8968368868337559369,

                          2992811758677295509,

Check warning

Code scanning / detekt

This expression contains a magic number. Consider defining it to a well named constant. Warning

This expression contains a magic number. Consider defining it to a well named constant.

metamodel-export/src/main/kotlin/org/modelix/metamodel/export/MPSMetaModelExporter.kt

    
                          "memberId",

                      )

                      val attributeInfoRole: SProperty = MetaAdapterFactory.getProperty(

                          -4094437568663370681,

Check warning

Code scanning / detekt

This expression contains a magic number. Consider defining it to a well named constant. Warning

This expression contains a magic number. Consider defining it to a well named constant.

metamodel-export/src/main/kotlin/org/modelix/metamodel/export/MPSMetaModelExporter.kt

    
                      )

                      val attributeInfoRole: SProperty = MetaAdapterFactory.getProperty(

                          -4094437568663370681,

                          -8968368868337559369,

Check warning

Code scanning / detekt

This expression contains a magic number. Consider defining it to a well named constant. Warning

This expression contains a magic number. Consider defining it to a well named constant.

metamodel-export/src/main/kotlin/org/modelix/metamodel/export/MPSMetaModelExporter.kt

    
                      val attributeInfoRole: SProperty = MetaAdapterFactory.getProperty(

                          -4094437568663370681,

                          -8968368868337559369,

                          2992811758677295509,

Check warning

Code scanning / detekt

This expression contains a magic number. Consider defining it to a well named constant. Warning

This expression contains a magic number. Consider defining it to a well named constant.

metamodel-export/src/main/kotlin/org/modelix/metamodel/export/MPSMetaModelExporter.kt

    
                          -4094437568663370681,

                          -8968368868337559369,

                          2992811758677295509,

                          7588428831955550663,

Check warning

Code scanning / detekt

This expression contains a magic number. Consider defining it to a well named constant. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet