Skip to content

Conversation

abstraktor
Copy link
Collaborator

Changes

  • feat(metamodel-export): serialize annotations on concept nodes into the metamodel json

Copy link
Contributor

github-actions bot commented Aug 19, 2025

Test Results

  227 files    227 suites   44m 27s ⏱️
1 250 tests 1 241 ✅ 9 💤 0 ❌
1 260 runs  1 251 ✅ 9 💤 0 ❌

Results for commit 38e1ac1.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 19, 2025

JVM coverage report

Overall Project 58.26% -0.08%
Files changed 5.59%

File Coverage
MetaModelData.kt 44.06% 🍏
MPSModelExporter.kt 0% -29.73%
MPSMetaModelExporter.kt 0% -3.38%

for (reference: SReference in node.references) {
references[reference.link.name] = reference.targetNodeReference.toString()
companion object {
fun exportNode(node: SNode): NodeData {

Check warning

Code scanning / detekt

The function exportNode is missing documentation. Warning

The function exportNode is missing documentation.
@abstraktor abstraktor force-pushed the feature/export-concept-annotations branch from 8adccd3 to 788c514 Compare August 20, 2025 07:14
@abstraktor abstraktor force-pushed the feature/export-concept-annotations branch from 788c514 to 38e1ac1 Compare August 20, 2025 08:46
val smodelAttribute: SContainmentLink = MetaAdapterFactory.getContainmentLink(
-0x3154ae6ada15b0deL,
-0x646defc46a3573f4L,
0x10802efe25aL,

Check warning

Code scanning / detekt

This expression contains a magic number. Consider defining it to a well named constant. Warning

This expression contains a magic number. Consider defining it to a well named constant.
-0x3154ae6ada15b0deL,
-0x646defc46a3573f4L,
0x10802efe25aL,
0x47bf8397520e5942L,

Check warning

Code scanning / detekt

This expression contains a magic number. Consider defining it to a well named constant. Warning

This expression contains a magic number. Consider defining it to a well named constant.
@slisson
Copy link
Member

slisson commented Aug 21, 2025

I would prefer representing the supported annotations as separate data classes instead of exporting them as NodeData.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants