Skip to content

Conversation

@abstraktor
Copy link
Collaborator

Changes

- creating a new child node had yielded a :$id:$name role which had led to duplicate caches entries in ReactiveINodeJS
- added regression test for it
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

Test Results

146 files  146 suites   44m 16s ⏱️
795 tests 786 ✅ 9 💤 0 ❌
805 runs  796 ✅ 9 💤 0 ❌

Results for commit 5fe3001.

♻️ This comment has been updated with latest results.

- to make sure we don't register the languages in one and wrap the nodes in another registry
- the issue sometimes shows up when depending on model-client, ts-model-api and vue-model-api (sometimes causing multiple instances of the same js package)
- avoids not finding concepts albeit them being registered
- ESNext produces ES Modules (ESM)
- eases bundling it in vite projects with moduleResolution: bundler
- ESM allows treeshaking the assembled projects, reducing their file size
@abstraktor abstraktor force-pushed the fix/reactivity-with-roles branch from 15947e0 to 5fe3001 Compare January 15, 2026 10:52
@abstraktor
Copy link
Collaborator Author

I was hunting ghosts here. The issue is already solved since 17.0.2. I extraced code quality improvements into #2290

@abstraktor abstraktor closed this Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants