refactor: unify the progress bar management#119
Merged
Conversation
chlins
force-pushed
the
refactor/progress-bar
branch
from
8a572d0 to
7115d86
Compare
chlins
force-pushed
the
refactor/progress-bar
branch
from
7115d86 to
0bc013d
Compare
gaius-qi
requested changes
Mar 12, 2025
chlins
force-pushed
the
refactor/progress-bar
branch
from
0bc013d to
a7917c4
Compare
Signed-off-by: chlins <chlins.zhang@gmail.com>
chlins
force-pushed
the
refactor/progress-bar
branch
from
a7917c4 to
56045dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to the
modctlproject, including dependency updates, the addition of a new progress bar feature, and modifications to the build process to support progress tracking. The most important changes are summarized below:Dependency Updates:
go.modincludinggithub.com/chelnak/ysmrr,github.com/fatih/color,github.com/mattn/go-colorable, andgithub.com/mattn/go-isatty[1] [2] [3].golang.org/x/netto versionv0.34.0.New Progress Bar Feature:
ProgressBarimplementation ininternal/pb/pb.goto provide progress tracking for various build stages.Build Process Enhancements:
ProgressBarinto the build process inpkg/backend/build.goto track progress for building layers, config, and manifest [1] [2].Builderinterface and its implementation inpkg/backend/build/builder.goto accept hooks for progress tracking [1] [2] [3].Test Adjustments:
pkg/backend/build/builder_test.goto accommodate changes in theBuilderinterface and ensure proper handling of progress tracking hooks [1] [2] [3].These changes collectively improve the build process by providing real-time progress updates and ensuring better dependency management.