feat: add --insecure for login command to skip tls verify#139
Merged
Conversation
Signed-off-by: chlins <chlins.zhang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for insecure connections to the registry by adding a new
Insecureflag and updating the relevant code to handle this new option. The most important changes include modifications to the command-line interface, backend login logic, and configuration structure.Command-line Interface Updates:
--insecureflag to thelogincommand to allow insecure connections to the registry (cmd/login.go).Backend Login Logic:
pkg/backend/login.go).Loginfunction to configure the HTTP client with theInsecureSkipVerifyoption based on the newInsecureflag (pkg/backend/login.go).Configuration Structure:
Insecureboolean field to theLoginstruct to store the insecure connection option (pkg/config/login.go).Insecurefield in theNewLoginfunction to its default value (pkg/config/login.go).