Skip to content

feat: support build with unknown type#203

Closed
aftersnow wants to merge 7 commits intomainfrom
support-build-unknown-type
Closed

feat: support build with unknown type#203
aftersnow wants to merge 7 commits intomainfrom
support-build-unknown-type

Conversation

@aftersnow
Copy link
Contributor

No description provided.

Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
Added validation in the workspace generation process to enforce limits on single file size (128GB), maximum file count (1024), and total workspace size (8TB). Included unit tests to verify these constraints.

Signed-off-by: Zhao Chen <zhaochen.zju@gmail.com>
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @aftersnow, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the modelfile generation process from a workspace directory. It removes the option to ignore unrecognized file types, opting instead for a size-based heuristic to classify unknown files as either model weights or code. Additionally, it introduces validation and size/count limits for the workspace to prevent issues with overly large or complex directories.

Highlights

  • Unknown File Type Handling: The --ignore-unrecognized-file-types flag and corresponding internal logic have been deprecated. Instead of ignoring or erroring on unknown file types during workspace scanning, the generator now attempts to classify them based on size: files larger than 128MB are treated as potential model weight files, while smaller unknown files are added to the code list.
  • Workspace Validation and Limits: Added initial validation for the workspace directory to ensure it exists, is a directory (not a symlink), and is not empty. New limits are introduced for the workspace: a single file cannot exceed 128GB, the total number of files cannot exceed 1024, and the total workspace size cannot exceed 8TB.
  • Expanded Recognized File Types: Significantly expanded the lists of recognized file extensions for configuration, model, code, and documentation files to include a wider variety of common formats used in ML and software development.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for building modelfiles even with unknown file types, adds comprehensive workspace validation, and imposes limits on file size and workspace size. It also expands the list of recognized file patterns and deprecates the ignore-unrecognized-file-types flag.

@aftersnow aftersnow changed the title Support build unknown type feat: support build unknown type Jun 16, 2025
@aftersnow aftersnow changed the title feat: support build unknown type feat: support build with unknown type Jun 16, 2025
@aftersnow
Copy link
Contributor Author

#210

@aftersnow aftersnow closed this Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants