refactor: move the PullByDragonfly as private method

[chlins]

This pull request refactors the handling of Dragonfly-based artifact pulling by removing the PullByDragonfly method from the Backend interface and consolidating its logic into the existing Pull method. This simplifies the codebase by reducing redundancy and improving maintainability.

Backend Interface Refactoring:

• Removed the PullByDragonfly method from the Backend interface in pkg/backend/backend.go. The logic is now encapsulated within the Pull method.

Consolidation of Dragonfly Logic:

• Updated the Pull method in pkg/backend/pull.go to internally handle Dragonfly-specific logic when a DragonflyEndpoint is specified. This eliminates the need for a separate PullByDragonfly method.

Method Renaming:

• Renamed the PullByDragonfly method to pullByDragonfly in pkg/backend/pull_by_d7y.go to reflect its new role as an internal helper function.

Code Cleanup:

• Removed the now-unused PullByDragonfly logic and associated mock functions from test/mocks/backend/backend.go. This includes the mock implementation and helper methods for testing.

Simplification of Pull Command:

• Simplified the runPull function in cmd/pull.go by removing the conditional logic for PullByDragonfly and relying solely on the updated Pull method.

[gemini-code-assist]

Summary of Changes

Hello @chlins, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the artifact pulling mechanism by integrating Dragonfly-specific logic directly into the main Pull method. My aim was to simplify the Backend interface, reduce redundancy, and improve maintainability by making the Dragonfly-specific pull functionality an internal helper rather than a separate public interface method. This change streamlines the pulling process and cleans up related code paths.

Highlights

• Interface Simplification: I've removed the PullByDragonfly method from the Backend interface in pkg/backend/backend.go. This simplifies the interface by consolidating Dragonfly-specific pulling logic.
• Logic Consolidation: The Pull method in pkg/backend/pull.go now internally handles Dragonfly-specific pulling. If a DragonflyEndpoint is specified in the configuration, it delegates to the newly private Dragonfly pull function.
• Method Privatization: The dedicated Dragonfly pulling function in pkg/backend/pull_by_d7y.go has been renamed from PullByDragonfly to pullByDragonfly, making it an internal helper method.
• Command Line Simplification: The runPull function in cmd/pull.go has been simplified. It no longer contains conditional logic to call either Pull or PullByDragonfly, relying solely on the updated Pull method.
• Mock Cleanup: Associated mock functions and types for the PullByDragonfly method have been removed from test/mocks/backend/backend.go, cleaning up the test infrastructure.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the Dragonfly artifact pulling logic. The PullByDragonfly method has been removed from the public Backend interface and its functionality is now consolidated within the Pull method, which internally calls a private pullByDragonfly helper. This change simplifies the interface, improves code organization, and enhances maintainability. The updates to the command-line tool and mock objects are consistent with these changes. I have included suggestions to improve comment clarity.

[gaius-qi]

LGTM