fix: fix progress bar stuck when error occurred during pull/push#65
Merged
fix: fix progress bar stuck when error occurred during pull/push#65
Conversation
Signed-off-by: chlins <chlins.zhang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces an
Abortmethod to theProgressBarclass and integrates it into various error handling scenarios within thepullIfNotExistandpushIfNotExistfunctions. The most important changes include the addition of theAbortmethod and its usage to handle errors more gracefully by aborting the progress bar when an error occurs.Enhancements to error handling:
pkg/backend/progress.go: Added a newAbortmethod to theProgressBarclass to abort the progress bar for a given descriptor.Integration of the
Abortmethod in error scenarios:pkg/backend/pull.go: Updated thepullIfNotExistfunction to callpb.Abort(desc)when reading the manifest fails.pkg/backend/pull.go: Updated thepullIfNotExistfunction to callpb.Abort(desc)when pushing a blob fails.pkg/backend/push.go: Updated thepushIfNotExistfunction to callpb.Abort(desc)when pushing the manifest fails.pkg/backend/push.go: Updated thepushIfNotExistfunction to callpb.Abort(desc)when pushing a blob fails.