refactor: change regex match to the glob path pattern#73
Merged
Conversation
479956c to
30dd426
Compare
Member
|
@chlins Fix lint. |
Signed-off-by: chlins <chlins.zhang@gmail.com>
30dd426 to
b6268d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
backendpackage, focusing on refactoring the processor logic and improving theBuildfunction. The most important changes include the introduction of abasestruct for processors, modifications to theBuildfunction, and updates to the processor implementations and their corresponding tests.Refactoring and Enhancements:
Introduction of
basestruct for processors:basestruct inpkg/backend/processor/base.goto handle common processor logic, including theProcessmethod.licenseProcessor,modelProcessor, andmodelConfigProcessorto utilize the newbasestruct for processing files. [1] [2] [3]Modifications to the
Buildfunction:defaultProcessorsandgetProcessorsmethods to be part of thebackendstruct, allowing them to access thestoreand other members.processmethod to simplify file processing by removing the directory walking logic and using theProcessmethod of each processor.Updates to processor implementations:
NewLicenseProcessor,NewModelProcessor, andNewModelConfigProcessorto acceptstore,mediaType, andpatternsparameters, and to use thebasestruct for processing. [1] [2] [3]Testing Improvements:
licenseProcessor,modelProcessor, andmodelConfigProcessorto use thesuitepackage for better test organization and setup. [1] [2] [3]Additional Changes:
BuildLayerfunction to maintain consistency.