Skip to content

fix: check tag existence during build #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaius-qi merged 1 commit into from
Feb 26, 2025
Merged

fix: check tag existence during build #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module github.com/CloudNativeAI/modctl
go 1.23.3

require (
github.com/CloudNativeAI/model-spec v0.0.0-20250212030633-7aabe2b8eadc
github.com/CloudNativeAI/model-spec v0.0.1
github.com/distribution/distribution/v3 v3.0.0-rc.3
github.com/distribution/reference v0.6.0
github.com/dustin/go-humanize v1.0.1
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
github.com/CloudNativeAI/model-spec v0.0.0-20250212030633-7aabe2b8eadc h1:EmVmYn5o4jGweOlvjsbsdeSlSpNYvWPQ2muLaQXT1L8=
github.com/CloudNativeAI/model-spec v0.0.0-20250212030633-7aabe2b8eadc/go.mod h1:3U/4zubBfbUkW59ATSg41HnkYyKrKUcKFH/cVdoPQnk=
github.com/CloudNativeAI/model-spec v0.0.1 h1:BgVIStKTLuL1DrLC5A/gmHcR8TEhFCDz9+fYdCUa/CY=
github.com/CloudNativeAI/model-spec v0.0.1/go.mod h1:3U/4zubBfbUkW59ATSg41HnkYyKrKUcKFH/cVdoPQnk=
github.com/VividCortex/ewma v1.2.0 h1:f58SaIzcDXrSy3kWaHNvuJgJ3Nmz59Zji6XoJR/q1ow=
github.com/VividCortex/ewma v1.2.0/go.mod h1:nz4BbCtbLyFDeC9SUHbtcT5644juEuWfUAUnGx7j5l4=
github.com/acarl005/stripansi v0.0.0-20180116102854-5a71ef0e047d h1:licZJFw2RwpHMqeKTCYkitsPqHNxTmd4SNR5r94FGM8=
Expand Down
4 changes: 4 additions & 0 deletions pkg/backend/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ func (b *backend) Build(ctx context.Context, modelfilePath, workDir, target stri
}

repo, tag := ref.Repository(), ref.Tag()
if tag == "" {
return fmt.Errorf("tag is required")
}

layers := []ocispec.Descriptor{}
layerDescs, err := b.process(ctx, workDir, repo, b.getProcessors(modelfile)...)
if err != nil {
Expand Down
Loading