Conversation
Signed-off-by: chlins <chlins.zhang@gmail.com>
84c1e4c to
47152e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
tagcommand to the CLI and updates the backend to support tagging model artifacts. Additionally, it modifies theMakefileto handle the installation ofmockeryusinggo installinstead of Homebrew. Below are the most important changes:Closes: #89
New
tagCommand:cmd/root.go: AddedtagCmdto the root command.cmd/tag.go: Introduced thetagcommand implementation, which includes the command definition and therunTagfunction to handle the tagging logic.Backend Updates:
pkg/backend/backend.go: Added theTagmethod to theBackendinterface.pkg/backend/tag.go: Implemented theTagmethod to create a new tag that refers to the source model artifact.pkg/backend/tag_test.go: Added unit tests for theTagmethod to ensure its correct functionality.Storage Interface Enhancements:
pkg/storage/storage.go: Updated theStorageinterface to include theMountBlobmethod.pkg/storage/distribution/distribution.go: Implemented theMountBlobmethod to mount blobs in the storage.Mockery Installation Update:
Makefile: Changed thecheck-mockeryandinstall-mockerytargets to usego installfor installingmockeryinstead of Homebrew, and introduced theMOCKERY_VERSIONvariable. [1] [2]