Conversation
ef04cf0 to
dc0c299
Compare
Signed-off-by: chlins <chlins.zhang@gmail.com>
dc0c299 to
4218bdc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several improvements to the tar and untar functionality in the
archiverpackage, as well as some enhancements in the backend build and extract processes. The most important changes include updating theTarandUntarfunctions to handle directories and file paths more robustly, and adding file type checks in the build process.Improvements to tar and untar functionality:
pkg/archiver/archiver.go: Enhanced theTarfunction to handle directories and preserve directory structures. Updated theUntarfunction to sanitize file paths and create necessary directories. [1] [2]Backend build process enhancements:
pkg/backend/build/build.go: Added a check in theBuildLayerfunction to ensure the path is not a directory, as directories are not supported yet.Code cleanup:
pkg/backend/extract.go: Removed unused imports and simplified theexportModelArtifactfunction by eliminating redundant directory structure restoration. [1] [2]