Skip to content

Conversation

@tarilabs
Copy link
Member

@tarilabs tarilabs commented Jul 7, 2025

Description

followup to #81,
since we moved there from mediatype prefix from vnd.cnai.* to vnd.cncf.*
it seems to me we should do likewise for the Annotations;

wdyt?

Related Issue

see followup to #81

Motivation and Context

see followup to #81

followup to modelpack#81

Signed-off-by: tarilabs <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @tarilabs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating and standardizing the annotation prefixes used throughout the project's documentation and Go language specifications. The change involves migrating from an org.cnai.model prefix to org.cncf.model, which is a follow-up to a previous effort to align media type prefixes, thereby enhancing overall consistency in naming conventions.

Highlights

  • Annotation Prefix Standardization: The pull request standardizes the annotation prefixes from org.cnai.model to org.cncf.model to align with previous changes made for media type prefixes, ensuring consistency across the project's specifications.
  • Documentation Update: The docs/annotations.md file has been updated to reflect the new org.cncf.model prefix for all defined layer annotation keys, including filepath, file.metadata+json, and file.mediatype.untested.
  • Go Constants Alignment: The specs-go/v1/annotations.go file has been modified to update the Go constants for AnnotationFilepath, AnnotationFileMetadata, and AnnotationMediaTypeUntested to use the org.cncf.model prefix, ensuring the Go implementation matches the updated specification.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@tarilabs tarilabs added the enhancement New feature or request label Jul 7, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the annotation prefixes from org.cnai.* to org.cncf.* to align with changes in the media type prefixes. The changes are applied consistently in both the Go constants file and the corresponding documentation. The modifications are correct and achieve the stated goal.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@bergwolf bergwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bergwolf bergwolf merged commit 14d4f12 into modelpack:main Jul 14, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants