Skip to content

Conversation

@tarilabs
Copy link
Member

@tarilabs tarilabs commented Jul 7, 2025

Description

aligns with the name of the project Sandbox

Related Issue

n/a

Motivation and Context

as description

@tarilabs tarilabs added the documentation Improvements or additions to documentation label Jul 7, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @tarilabs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating project name references across various documentation and Go source files. The changes align the codebase with the new project name, 'CNCF ModelPack', replacing previous mentions of 'CNAI' or 'Cloud Native AI Model Specification'. While the PR title mentions aligning to 'Sandbox', the specific textual changes observed are for 'CNCF ModelPack', indicating this is likely a component within the broader 'Sandbox' initiative.

Highlights

  • Project Name Standardization: Updated all instances of the former project name, 'CNAI' or 'Cloud Native AI Model Specification', to 'CNCF ModelPack' or 'CNCF ModelPack Specification' in both documentation and Go source code files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project name from 'CNAI' to 'CNCF ModelPack' in the code of conduct and several copyright headers. The changes are correct and align with the project's rebranding. However, the renaming appears incomplete, as some files (e.g., schema/config_test.go) still reference the old 'CNAI Authors'. For consistency, I recommend a follow-up to update all remaining occurrences. The PR title and description could also be more explicit about the renaming to 'CNCF ModelPack' instead of the more generic 'Sandbox name'.

# CNCF ModelPack Community Code of Conduct

The Cloud Native AI Model Specification project follows the [CNCF Code of Conduct](https://github.com/cncf/foundation/blob/main/code-of-conduct.md).
The CNCF ModelPack Specification project follows the [CNCF Code of Conduct](https://github.com/cncf/foundation/blob/main/code-of-conduct.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The project name appears to be 'CNCF ModelPack', as used in the title on line 1 and in the project's README.md. For better consistency and clarity, it would be best to use this name here as well, instead of 'CNCF ModelPack Specification project'.

Suggested change
The CNCF ModelPack Specification project follows the [CNCF Code of Conduct](https://github.com/cncf/foundation/blob/main/code-of-conduct.md).
The CNCF ModelPack project follows the [CNCF Code of Conduct](https://github.com/cncf/foundation/blob/main/code-of-conduct.md).

@caozhuozi
Copy link
Contributor

good catch! ❤️

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bergwolf bergwolf merged commit 8b3a579 into modelpack:main Jul 14, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants