Skip to content

Conversation

@jc200808
Copy link
Contributor

@jc200808 jc200808 commented Jan 9, 2026

OpenJudge Version

[The version of OpenJudge you are working on, e.g. import openjudge; print(openjudge.__version__)]

Description

[Please describe the background, purpose, changes made, and how to test this PR]

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with pre-commit run --all-files command
  • All tests are passing
  • Docstrings are in Google style
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jc200808, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the example code within the openjudge grading modules, particularly for agent-based and common evaluation functionalities. The primary goal is to enhance the usability and correctness of docstring examples by adapting asynchronous function calls for direct execution and refining how multi-line prompt templates are defined and utilized, leading to cleaner and more robust code.

Highlights

  • Asynchronous Example Updates: Modified docstring examples across numerous agent and common graders to correctly execute asynchronous aevaluate calls using asyncio.run(), ensuring examples are directly runnable without needing an explicit async context.
  • Prompt Template Processing Enhancement: Improved the handling of multi-line prompt strings in common graders (correctness, hallucination, harmfulness, instruction_following, relevance) by applying textwrap.dedent().strip() directly to the prompt definitions, which simplifies ChatMessage content assignment and ensures consistent formatting.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two main improvements across several grader files. First, it updates the example code in docstrings to correctly use asyncio.run() for asynchronous calls, ensuring the examples are runnable and accurate. Second, it refactors the processing of prompt templates in the common graders by applying textwrap.dedent and .strip() at the constant definition, which cleans up the code and improves maintainability. The changes are well-implemented and consistent across all affected files. Overall, this is a solid contribution that improves code quality and documentation.

@ployts ployts changed the title feat: update example code and template processing in agent and common… feat: update example code and template processing in agent and common graders Jan 9, 2026
Copy link
Collaborator

@ployts ployts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ployts ployts merged commit d722e38 into modelscope:main Jan 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants