Skip to content

Fix unittest workflow #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pan-x-c merged 1 commit into from
Apr 24, 2025
Merged

Fix unittest workflow #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/docker/docker-compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
services:
trinity-node-1:
image: trinity-rft:latest-unittest
user: "${UID}:${GID}"
pull_policy: never
command: sh -c "pip install -e .[dev] && ray start --head --dashboard-host 0.0.0.0 --include-dashboard true --block"
environment:
Expand All @@ -27,7 +26,6 @@ services:

trinity-node-2:
image: trinity-rft:latest-unittest
user: "${UID}:${GID}"
pull_policy: never
command: sh -c "pip install -e .[dev] && ray start --address=trinity-node-1:6379 --block"
environment:
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/unittest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,24 +24,18 @@ jobs:
- name: Setup docker compose
working-directory: trinity-${{ github.run_id }}/.github/workflows/docker
run: |
export UID
export GID=$(id -g)
docker compose up -d
sleep 15s

- name: Check ray status
working-directory: trinity-${{ github.run_id }}/.github/workflows/docker
run: |
export UID
export GID=$(id -g)
docker compose exec trinity-node-1 ray status
docker compose exec trinity-node-2 ray status

- name: Run unittest
working-directory: trinity-${{ github.run_id }}/.github/workflows/docker
run: |
export UID
export GID=$(id -g)
docker compose exec trinity-node-1 pytest tests --ignore=tests/data --ctrf report.json
continue-on-error: true

Expand All @@ -64,8 +58,6 @@ jobs:
working-directory: trinity-${{ github.run_id }}/.github/workflows/docker
if: always()
run: |
export UID
export GID=$(id -g)
docker compose down --remove-orphans

- name: Cleanup workspace
Expand Down