-
Notifications
You must be signed in to change notification settings - Fork 47
fix: some hf dataset may need specified config name #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/run-unittest |
Summary
Failed TestsNo failed tests ✨ Flaky TestsNo flaky tests ✨ SkippedNo skipped tests ✨ Tests
Github Test Reporter by CTRF 💚 |
hiyuchang
reviewed
Apr 27, 2025
hiyuchang
reviewed
Apr 27, 2025
hiyuchang
reviewed
Apr 27, 2025
Co-authored-by: Yuchang Sun <[email protected]>
Co-authored-by: Yuchang Sun <[email protected]>
0x404
commented
Apr 27, 2025
0x404
commented
Apr 27, 2025
yanxi-chen
approved these changes
Apr 27, 2025
Collaborator
yanxi-chen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some hf dataset, such as openai/gsm8k has multi config (e.g., "main" and "socratic"), directly load dataset will lead to error. Instead, we should use the user specified
config_nameif provided, and if not, we simply try to load_dataset with dataset name.This PR also update
examples/grpo_gsm8k/gsm8k.yaml'sbuffer.train_dataset.pathfromsqlite:////gsm8k.dbtosqlite:///gsm8k.db, sincesqlite:////gsm8k.dbwill create the db file under the root directory (some may have no permission under a server's root directory), insteadsqlite:///gsm8k.dbwill create the db file under the current direcotry.Checklist
Please check the following items before code is ready to be reviewed.