Skip to content

Conversation

@pan-x-c
Copy link
Collaborator

@pan-x-c pan-x-c commented Apr 29, 2025

Description

Add unit tests for

  • queue buffer
  • explorer
  • trainer

Fix bugs

  • eval in explore mode
  • queue buffer writer
  • trainer can't stop
  • logits 0.0 when setting top-p/k
  • runner pool hang

Support Qwen3 series

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@pan-x-c pan-x-c added the testcase Improvements or additions to testcase label Apr 29, 2025
@pan-x-c pan-x-c changed the title [WIP] Add more unittest Add more unittest Apr 29, 2025
Copy link
Collaborator

@yanxi-chen yanxi-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pan-x-c pan-x-c changed the title Add more unittest Add more unittest and support Qwen3 Apr 30, 2025
@pan-x-c pan-x-c merged commit 3651ad8 into modelscope:main Apr 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testcase Improvements or additions to testcase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants